-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] fix connector mem scan limit adjustment when no chunk source #53112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate failedFailed conditions |
[BE Incremental Coverage Report]❌ fail : 8 / 11 (72.73%) file detail
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 8 / 8 (100.00%) file detail
|
@Mergifyio backport branch-3.4 |
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
…ource (#53112) Signed-off-by: yanz <[email protected]> (cherry picked from commit 14ccfcc)
…ource (#53112) Signed-off-by: yanz <[email protected]> (cherry picked from commit 14ccfcc) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/planner/MetaScanNode.java # fe/fe-core/src/main/java/com/starrocks/planner/OlapScanNode.java # fe/fe-core/src/main/java/com/starrocks/planner/ScanNode.java # fe/fe-core/src/main/java/com/starrocks/planner/SchemaScanNode.java
…ource (#53112) Signed-off-by: yanz <[email protected]> (cherry picked from commit 14ccfcc) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/planner/OlapScanNode.java # fe/fe-core/src/main/java/com/starrocks/planner/ScanNode.java # fe/fe-core/src/main/java/com/starrocks/planner/SchemaScanNode.java
…ource (backport #53112) (#53162) Co-authored-by: RyanZ <[email protected]>
…ource (backport #53112) (#53163) Signed-off-by: yanz <[email protected]> Co-authored-by: RyanZ <[email protected]>
…ource (backport #53112) (#53164) Signed-off-by: yanz <[email protected]> Co-authored-by: RyanZ <[email protected]>
Why I'm doing:
This is the further improvement on this PR: #50686
We find a bad case that
And this case can be reproduced by following SQL
select lo_orderkey from ICE
has dataSo the execution profile looks like this
And if you look at
PeakIOTasks
ofICE
table, it's very low probably like 3-4, which is bad.The root cause is, since we have this PR: #50686
However, there is a corner case that: if the scan operator does not create any chunk source, it has no chance to adjust it's chunk usage back to 0. And it affects other scan operator's available mem limit, which leads to low io tasks.
What I'm doing:
This PR is to:
do_preapre
anddo_close
. so it will do adjustment even there is no chunk source created.scan_node_number
to more proper nameconnector_scan_node_number
. So there won't be problems if there are no-connector scan node and connector scan nodes in a single query.Fixes #50686
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: